Add test case for internal/errors/discoverer.go #874

hlts2 · 2020-12-08T06:04:44Z

Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com

Description:

I added the test cases for internal/errors/discoverer.go and comments.

grammar check passed

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.15.2
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.12.1

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

vdaas-ci · 2020-12-08T06:05:04Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master

internal/errors/discoverer_test.go

codecov · 2020-12-08T06:19:45Z

Codecov Report

Merging #874 (c9cd358) into master (f72ff79) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #874      +/-   ##
==========================================
+ Coverage   18.85%   18.92%   +0.07%     
==========================================
  Files         423      423              
  Lines       19600    19600              
==========================================
+ Hits         3696     3710      +14     
+ Misses      15685    15672      -13     
+ Partials      219      218       -1

Impacted Files	Coverage Δ
internal/errors/discoverer.go	`100.00% <ø> (+100.00%)`	⬆️
internal/worker/queue.go	`98.33% <0.00%> (-1.67%)`	⬇️
internal/errgroup/group.go	`92.42% <0.00%> (-1.52%)`	⬇️
internal/worker/worker.go	`82.29% <0.00%> (-1.05%)`	⬇️
internal/errors/errors.go	`31.57% <0.00%> (+15.78%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f72ff79...000659b. Read the comment docs.

internal/errors/discoverer_test.go

kevindiu

LGTM

github-actions · 2020-12-16T05:39:17Z

internal/errors/discoverer_test.go

@@ -0,0 +1,320 @@
+package errors


[golangci] _{reported by reviewdog 🐶}
package should be errors_test instead of errors (testpackage)

internal/errors/discoverer.go

kevindiu

LGTM

vankichi

I recommend you to use '' instead of `` when you'd like to use the symbol for wrapping the actual value in each test case name.
If you fix, LGTM

internal/errors/discoverer_test.go

kevindiu

LGTM

vankichi · 2020-12-21T05:39:40Z

/rebase
/format
/approve

vdaas-ci · 2020-12-21T05:40:18Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/discoverer-errors

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>

vdaas-ci · 2020-12-21T05:41:10Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

Signed-off-by: vdaas-ci <ci@vdaas.org>

vdaas-ci

[APPROVED] This PR is approved by vankichi.

hlts2 requested a review from kevindiu December 8, 2020 06:04

hlts2 self-assigned this Dec 8, 2020

github-actions bot added area/internal team/set SET team size/L type/test Adding tests priority/low labels Dec 8, 2020

github-actions bot reviewed Dec 8, 2020

View reviewed changes

internal/errors/discoverer_test.go Outdated Show resolved Hide resolved

internal/errors/discoverer_test.go Outdated Show resolved Hide resolved

kevindiu reviewed Dec 16, 2020

View reviewed changes

internal/errors/discoverer_test.go Outdated Show resolved Hide resolved

kevindiu previously approved these changes Dec 16, 2020

View reviewed changes

github-actions bot reviewed Dec 16, 2020

View reviewed changes

hlts2 changed the title ~~Add test case for internal/errors/discoverer.go~~ Add test case for internal/errors/discoverer.go Dec 17, 2020

hlts2 commented Dec 17, 2020

View reviewed changes

internal/errors/discoverer.go Outdated Show resolved Hide resolved

hlts2 dismissed kevindiu’s stale review via ce753c4 December 17, 2020 02:00

kevindiu previously approved these changes Dec 17, 2020

View reviewed changes

vankichi reviewed Dec 18, 2020

View reviewed changes

hlts2 dismissed kevindiu’s stale review via 9b30f7f December 21, 2020 01:06

kevindiu previously approved these changes Dec 21, 2020

View reviewed changes

hlts2 and others added 8 commits December 21, 2020 05:40

feat: add discoverer error test and comment

08e909d

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

fix: apply suggestion

2413981

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

Update internal/errors/discoverer.go

11d0d87

Update internal/errors/discoverer_test.go

749a9c8

Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>

Update internal/errors/discoverer_test.go

7a15aba

Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>

Update internal/errors/discoverer_test.go

b247c9b

Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>

Update internal/errors/discoverer_test.go

99eed8e

Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>

Update internal/errors/discoverer_test.go

90b1136

Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>

github-actions bot dismissed kevindiu’s stale review via 90b1136 December 21, 2020 05:40

github-actions bot force-pushed the test/internal/discoverer-errors branch from c9cd358 to 90b1136 Compare December 21, 2020 05:40

🤖 Update license headers / Format go codes and yaml files

000659b

Signed-off-by: vdaas-ci <ci@vdaas.org>

vdaas-ci approved these changes Dec 21, 2020

View reviewed changes

vankichi merged commit 933cba5 into master Dec 21, 2020

vankichi deleted the test/internal/discoverer-errors branch December 21, 2020 08:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test case for internal/errors/discoverer.go #874

Add test case for internal/errors/discoverer.go #874

hlts2 commented Dec 8, 2020 •

edited

Loading

vdaas-ci commented Dec 8, 2020

codecov bot commented Dec 8, 2020 •

edited

Loading

kevindiu left a comment

github-actions bot Dec 16, 2020

kevindiu left a comment

vankichi left a comment

kevindiu left a comment

vankichi commented Dec 21, 2020

vdaas-ci commented Dec 21, 2020

vdaas-ci commented Dec 21, 2020

vdaas-ci left a comment

Add test case for internal/errors/discoverer.go #874

Add test case for internal/errors/discoverer.go #874

Conversation

hlts2 commented Dec 8, 2020 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

vdaas-ci commented Dec 8, 2020

codecov bot commented Dec 8, 2020 • edited Loading

Codecov Report

kevindiu left a comment

Choose a reason for hiding this comment

github-actions bot Dec 16, 2020

Choose a reason for hiding this comment

kevindiu left a comment

Choose a reason for hiding this comment

vankichi left a comment

Choose a reason for hiding this comment

kevindiu left a comment

Choose a reason for hiding this comment

vankichi commented Dec 21, 2020

vdaas-ci commented Dec 21, 2020

vdaas-ci commented Dec 21, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

hlts2 commented Dec 8, 2020 •

edited

Loading

codecov bot commented Dec 8, 2020 •

edited

Loading